Conquer Club

Dako wrote:Why don't you make it into single requests on hover? Because it takes a long time to fetch game links anyway and most of the time I need 2-3 games out of 10 only.

As for [player] suggestion - yeah, that will be great as well.

Because I tend to use it in tournament or clanwar forum pages, where I'm interested in most of the games.
And I'd have to check, but I think it takes around 0.3 second to fetch 40 games now, that's quite good actually (it just doesn't annoy me). So I didn't need to make it faster, it looks like adding one more game isn't that expensive for the server, and I'm not that sure about firing multiple requests.

Maybe the question is whether there is an advantage to delaying the API request until the first hover. If all the games can be fetched at once with only a minor delay, it might be smoother to do it when the page loads. Most forum users are accustomed to a bit of a delay while loading a page, what with signatures and images and such being loaded. A small extra delay at that point might not be as annoying as the one now at first hover.

The other thing I would like to suggest is extending the @include directives to include https://www... .

ender516 wrote:Maybe the question is whether there is an advantage to delaying the API request until the first hover. If all the games can be fetched at once with only a minor delay, it might be smoother to do it when the page loads. Most forum users are accustomed to a bit of a delay while loading a page, what with signatures and images and such being loaded. A small extra delay at that point might not be as annoying as the one now at first hover.

The other thing I would like to suggest is extending the @include directives to include https://www... .

Actually, my main reason for updating it is introducing that lazy loading, I used to disable the script when going to pages with high amounts of games (clan league if I remember correctly), because that ment the page was a lot slower (10 seconds or so, api should have made it faster). And disabling/enabling is annoying. I could maybe make it an option though.

The https thing is something I can do though (or even you, since you can edit it on github ).

I guess the ultimate option technique would be an adjustable threshold: if there are less than N links on the page, then load immediately, else wait for first hover.

I will take a crack at github very soon. I just want to be sure that I do no damage.

ender516 wrote:By the way, does anyone besides me think that a popup for [player] links might be a nice addition to this script?

I believe I already mentioned that earlier in the thread. I would love to see a popup for player links.

MGB

MrGlassB wrote:

ender516 wrote:By the way, does anyone besides me think that a popup for player links might be a nice addition to this script?

I believe I already mentioned that earlier in the thread. I would love to see a popup for player links.

MGB

I am working on a popup for player links. Right now it is in a separate script for testing purposes, and I am about half done: I have code that will pop up over links that reference users by numerical ID, like those that appear in the header of a post or at the side with the avatars and stuff, but also need to handle links that reference users by name, which is what you get from ender516. Doing both in a simplistic way would be easy, but I am trying to come up with a way to avoid fetching the same user information both ways. Once I work that out, it may be easier to combine this fetching of user information with what Game Link is doing. If that doesn't work out, I will simply release my script separately.

Awesome.

MGB

I added the player state to the information (the red/green/yellow thingy indicating whose turn it is) on the github-version, and now it should work for https and thread/post previews too.

I would have taken a shot at the github version as you suggested, but I am having trouble installing git for Cygwin on my PC. I suspect that my disk is too close to full.

for some reason this does not work anymore

i keep getting this:

DiM wrote:for some reason this does not work anymore

i keep getting this:

I just tested it and it's working for me with that game number.

guys i was getting that then there is a update on page 7 i just clicked that then it works again this link

https://github.com/sherkaner/addons-for ... nk.user.js

eddie2 wrote:guys i was getting that then there is a update on page 7 i just clicked that then it works again this link

https://github.com/sherkaner/addons-for ... nk.user.js

Cheers eddie, it's working for me again.

safariguy5 wrote:

eddie2 wrote:guys i was getting that then there is a update on page 7 i just clicked that then it works again this link

https://github.com/sherkaner/addons-for ... nk.user.js

Cheers eddie, it's working for me again.

thanks, eddie! I have put this link in the OP

I have updated this script, now at version 1.5.0, to show the Special Gameplay information (None, Fog, Trench, or Fog Trench) in place of the Fog of War information seen formerly.

This usually works for me fine but for random game numbers recently, it tells me game information cant be found

Specific examples would be most helpful.

i have looks like i have had this update for sometime and forgot to post it
UPDATED!