Operation Drug War [Quenched]

[edbeard]

I'm doing a major overhaul because I don't like the way things have been named.

I'm taking my continent section and using your territories (since the centering is done on those).



I'm not looking at the centering at the moment. Though when I looked at it once I didn't see anything major.

[zimmah]

I'm doing a major overhaul because I don't like the way things have been named.

I'm taking my continent section and using your territories (since the centering is done on those).



I'm not looking at the centering at the moment. Though when I looked at it once I didn't see anything major.

what's wrong about the continent names?

[edbeard]

They just weren't how I wanted them to be. And, I have good reasons for the way I want them. No point getting into it all as it doesn't matter.


http://www.sendspace.com/file/k3d00l


This post to remind me to get Telvannia to fix the Vacant sector to be Vacants


Thanks again Zim! Please use the above link for XML Check post.

[zimmah]

i tried my very best to get them the best way, but you didn't specify how exactly you wanted them, well i guess you can fix them yourself anyways, i'll just check it over to see if it works, but i guess you can make it work. no problem at all for doing it, and i'm very sorry it took so long, just been very busy lately with a lot of unexpected things.

[zimmah]

i'm looking it over for you to see if there are any mistakes that slipped in while editting it.

i found this so far:

at the start of the file you forgot to put:

Code: Select all

<?xml version="1.0" ?>

and at the continents:

Code: Select all

- <continent>
  <name>Eight Phones</name>
  <bonus>2</bonus>
- <components>
  <territory>NW Phone</territory>
  <territory>NE Phone</territory>
  <territory>SW Phone</territory>
  <territory>SE Phone</territory>
  <territory>City Hall Phone</territory>
  <territory>Supply Phone</territory>
  <territory>Hideout Phone</territory>
  <territory>Stash House Phone</territory>
  </components>
  <required>2</required>
- <overrides>
  <override>Six Phones</override>
  </overrides>
  </continent>


you should either remove the

Code: Select all

<required>2</required>

or change the 2 into an 8 (you can just remove it because there are 8 Phones, and you need all of them for the bonus to be in effect, so a

Code: Select all

<required>

tag is not needed here.

still looking to see if there are any more mistakes, tho i don't think there are many mistakes.

btw one more thing, not really a mistake but still something worth mentioning:

Code: Select all

- <continent>
  <name>Leader or 2nd + Two Muscle</name>
  <bonus>4</bonus>
- <components>
  <continent>Leader or 2nd</continent>
  <continent>Two Muscle</continent>
  </components>
- <overrides>
  <override>Leader or 2nd + One Muscle</override>
  <override>Two Muscle</override>
  </overrides>
  </continent>
- <continent>


you override 'One Muscle', though you don't override 'Leader or 2nd' (you do this in all continents that look the same) i think you should also override 'Leader or 2nd, because otherwise you'll get the message 'Player X gets 0 armies for holding Leader or 2nd, even when someone gets the bonus for holding Leader or 2nd + X amount of Muscle, so i think you should override it.

and you can remove the

Code: Select all

<override>Leader or 2nd + One Muscle</override>

because one can never get this bonus anyways, because two muscle already overrides one muscle, so whenever someone holds Two Muscle + leader or 2nd, someone also holds Two Muscle, and since Two Muscle ALREADY overrides One Muscle, you don't have to override it (because then you just override something that already is overriden before, unneccesary tags (correct me if i'm wrong on this one) so i think you should leave them out.

i also think the way you did the Commissioner + Lieutenant + Patrol is a lot more complicated (and long) then it needs to be. but that might be just me. just compare it with the way i did it and you'll probably see what i mean. though if you do it my way the downside is you won't see how many patrols you own (it will just show you have Commisioner + Lieutenant + Patrol, but it doesn't state how many, however you can tell how many patrols you have by the bonus you get, so i thought it wasn't necessary). it's not wrong to do it your way, but i think you should know it can be simpler in another way (and personnaly i don't really think it's neccesary to do it your way in this case)

that's all. after this the territories start, and i guess you just copied that, so i already checked that part for bugs.

[edbeard]

I was deleting a bunch of stuff and must've deleted that first override in the Leader or 2nd + One Muscle continent by mistake. thanks!

regarding the

<override>Leader or 2nd + One Muscle</override>

because one can never get this bonus anyways, because two muscle already overrides one muscle, so whenever someone holds Two Muscle + leader or 2nd, someone also holds Two Muscle, and since Two Muscle ALREADY overrides One Muscle, you don't have to override it

hmm. You're probably right but this one worries me. Does an override work in the same way for components of another continent? I'd need to know exactly what an override does. I'd say it's best to leave this as it is and see what Forza says about it.


Regarding the patrol bonus, I want people to know how many patrol they hold in the bonus.



Here's the latest one. http://www.sendspace.com/file/k3d00l

[zimmah]

I was deleting a bunch of stuff and must've deleted that first override in the Leader or 2nd + One Muscle continent by mistake. thanks!

regarding the

<override>Leader or 2nd + One Muscle</override>

because one can never get this bonus anyways, because two muscle already overrides one muscle, so whenever someone holds Two Muscle + leader or 2nd, someone also holds Two Muscle, and since Two Muscle ALREADY overrides One Muscle, you don't have to override it

hmm. You're probably right but this one worries me. Does an override work in the same way for components of another continent? I'd need to know exactly what an override does. I'd say it's best to leave this as it is and see what Forza says about it.


Regarding the patrol bonus, I want people to know how many patrol they hold in the bonus.



Here's the latest one. http://www.sendspace.com/file/k3d00l

still the same errors,

Code: Select all

- <continent>
  <name>Leader or 2nd + One Muscle</name>
  <bonus>2</bonus>
- <components>
  <continent>Leader or 2nd</continent>
  <continent>One Muscle</continent>
  </components>
- <overrides>
  <override>One Muscle</override>
  <continent>Leader or 2nd</continent>
  </overrides>
  </continent>


i'll just download the file, fix that one line, leave the rest as it is, and repost it.

i will also ask them about the override issue, they can tell us whether it's better to leave them in or delete them.

[edbeard]

what are you talking about?

It's fixed. Everything is overrided that needs to be.


edit: also, I realized that the overrides as I have done it are correct. If I didn't do it that way, then I'd have to override Leader or 2nd in every continent anyway so the number of overrides are the same and this one is safer.


edit 2: see it works because you don't need to actually own a continent to override it. so we don't have to worry about the does an override just kill the bonus or does it make it so you technically don't own that continent

[zimmah]

what are you talking about?

It's fixed. Everything is overrided that needs to be.


edit: also, I realized that the overrides as I have done it are correct. If I didn't do it that way, then I'd have to override Leader or 2nd in every continent anyway so the number of overrides are the same and this one is safer.

look, first of all you wrote CONTINENT, where you should write OVERRIDE, so it will give an error.
second, you only used it in the first one of continents and not in the rest (i'm not sure if the rest is needed, but i think it is needed, because the first one doesn't override the ones that come after it, in fact it's vice versa, the ones that come last override the ones before them, but they won't override things that haven't been stated before, therefore you'll have to repeat it.

anyways i put the right file in the XML Checks.


edit: i don't think you're right at edit1, i put the <override>Leader or 2nd</override> tag in all continents becuase i think if you put it in the first one only it will not work, tho i'm not 100% sure at it. someone who knows for sure reply on this please?

[edbeard]

ok. I was confused because you said it was the 'same error'


you don't need it in the rest of the continents.

Lets say I own continent C and it overrides continent B

and in continent B I override continent A

then continent C overrides continent A


This is why I include the <override>Leader or 2nd + One Muscle</override> so that it overrides the continent which overrides <override>Leader or 2nd</override>

I have asked this of yeti before and he confirmed it. As long as a previous overrided continent overrides the one in question it works. This is why we were able to remove large chunks of overrides before, remember?



so please remove that question from the XML check thread as the way I have it is correct.

[zimmah]

ok. I was confused because you said it was the 'same error'


you don't need it in the rest of the continents.

Lets say I own continent C and it overrides continent B

and in continent B I override continent A

then continent C overrides continent A


This is why I include the <override>Leader or 2nd + One Muscle</override> so that it overrides the continent which overrides <override>Leader or 2nd</override>

I have asked this of yeti before and he confirmed it. As long as a previous overrided continent overrides the one in question it works. This is why we were able to remove large chunks of overrides before, remember?



so please remove that question from the XML check thread as the way I have it is correct.

you are right about that, but are you sure this is the same? i just want to be sure it's 100% correct

[AndyDufresne]

Crazy XML! Nice to see you attempting it, Zimmah. Always good to have a few people lurking on CC with some knowledge of XML.


--Andy

[edbeard]

OK. I was wrong. Apparently, a continent DOES need to be held for the override to trigger.

viewtopic.php?f=127&t=47308&p=1227110&hilit=+override#p1227110


here's the fix for that section.

Code: Select all


<continent>
<name>Leader or 2nd + One Muscle</name>
<bonus>2</bonus>
<components>
<continent>Leader or 2nd</continent>
<continent>One Muscle</continent>
</components>
<overrides>
<override>One Muscle</override>
<continent>Leader or 2nd</continent>
</overrides>
</continent>

<continent>
<name>Leader or 2nd + Two Muscle</name>
<bonus>4</bonus>
<components>
<continent>Leader or 2nd</continent>
<continent>Two Muscle</continent>
</components>
<overrides>
<override>Leader or 2nd</override>
<override>Two Muscle</override>
</overrides>
</continent>

<continent>
<name>Leader or 2nd + Three Muscle</name>
<bonus>6</bonus>
<components>
<continent>Leader or 2nd</continent>
<continent>Three Muscle</continent>
</components>
<overrides>
<override>Leader or 2nd</override>
<override>Three Muscle</override>
</overrides>
</continent>

<continent>
<name>Leader or 2nd + Four Muscle</name>
<bonus>8</bonus>
<components>
<continent>Leader or 2nd</continent>
<continent>Four Muscle</continent>
</components>
<overrides>
<override>Leader or 2nd</override>
<override>Four Muscle</override>
</overrides>
</continent>

<continent>
<name>Leader or 2nd + Five Muscle</name>
<bonus>10</bonus>
<components>
<continent>Leader or 2nd</continent>
<continent>Five Muscle</continent>
</components>
<overrides>
<override>Leader or 2nd</override>
<override>Five Muscle</override>
</overrides>
</continent>

<continent>
<name>Leader or 2nd + Six Muscle</name>
<bonus>12</bonus>
<components>
<continent>Leader or 2nd</continent>
<continent>Six Muscle</continent>
</components>
<overrides>
<override>Leader or 2nd</override>
<override>Six Muscle</override>
</overrides>
</continent>

<continent>
<name>Leader or 2nd + Seven Muscle</name>
<bonus>14</bonus>
<components>
<continent>Leader or 2nd</continent>
<continent>Seven Muscle</continent>
</components>
<overrides>
<override>Leader or 2nd</override>
<override>Seven Muscle</override>
</overrides>
</continent>

<continent>
<name>Leader or 2nd + Eight Muscle</name>
<bonus>16</bonus>
<components>
<continent>Leader or 2nd</continent>
<continent>Eight Muscle</continent>
</components>
<overrides>
<override>Leader or 2nd</override>
<override>Eight Muscle</override>
</overrides>
</continent>




I'll need to go over the rest of the XML to see if this affects the rest of the code. For now, if possible, please delete your post in the XML Check thread so I can look over the rest of it.


Thanks again, Zim. Especially for putting up with my mistake!

[zimmah]

i removed the link of the xml and told them i'll repost it later.

i have backups of all XML files and i can edit it in just seconds. i go to sleep now though, i hope you can tell me what overrides will work best, cuz i'm getting confused now. though i think the one you posted last will do just fine. maybe ask yeti?

[edbeard]

I'm still a bit concerned about when the overrides come into play.

Do I no longer hold a continent because I've overrided a component that is needed for it to be held?


The reason I ask is because for example

Code: Select all

<continent>
<name>Commissioner + Lieutenant + Two Patrol</name>
<bonus>2</bonus>
<components>
<territory>Commissioner</territory>
<territory>Lieutenant</territory>
<continent>Two Patrol</continent>
</components>
<overrides>
<override>Commissioner + Lieutenant + One Patrol</override>
<override>Two Patrol</override>
</overrides>
</continent>

if I override 'two patrol', then do I no longer hold 'one patrol' since it overrides 'one patrol' and therefore holding the 'commish + lt. + one patrol' is not possible?


NB: I wanted this to be its own post because it's important (message regarding this sent to Lack and cced Andy).

[zimmah]

btw, while you're at it, could you also check if i made all the borders right? there is some kind of tool for it somewhere also in the map foundry

if you need a link to the xml to run the map checker use this one http://www.freewebs.com/zimri1987/odw2.xml it's the latests one i have.

if you won't do it i will do it tomorrow. just to make sure all the borders are right.

[zimmah]

I'm still a bit concerned about when the overrides come into play.

Do I no longer hold a continent because I've overrided a component that is needed for it to be held?


The reason I ask is because for example

Code: Select all

<continent>
<name>Commissioner + Lieutenant + Two Patrol</name>
<bonus>2</bonus>
<components>
<territory>Commissioner</territory>
<territory>Lieutenant</territory>
<continent>Two Patrol</continent>
</components>
<overrides>
<override>Commissioner + Lieutenant + One Patrol</override>
<override>Two Patrol</override>
</overrides>
</continent>

if I override 'two patrol', then do I no longer hold 'one patrol' since it overrides 'one patrol' and therefore holding the 'commish + lt. + one patrol' is not possible?


NB: I wanted this to be its own post because it's important (message regarding this sent to Lack and cced Andy).

doesn't matter if you override 1 patrol, i don't really know what problem you think there is in this piece of code, cuz i don't see anything that might go wrong here. since it will override the continents only AFTER giving the bonus, so it won't for example override Two Patrol, then check if you hold Two patrol as a component. it will first see if you have Two Patrol, then grant you the bonus for having the continent, then override the overrides.

besides, i guess <override>Commissioner + Lieutenant + One Patrol</override> won't be needed either, pretty much for the same reason as the overrides in Leader/2nd + Muscle.

[zimmah]

Crazy XML! Nice to see you attempting it, Zimmah. Always good to have a few people lurking on CC with some knowledge of XML.


--Andy

thx.

well i think some expert should double check it anyways because it's pretty tricky and it has been changed 1000 times so there might be some errors in it i haven't seen, or i didn't recognise as an error, even though edbeard and I both check it, there might be some mistakes in it.

but i always try to post 100% perfect XML files even if they are difficult, in fact i like difficult ones more then the easy ones. it's a challenge for me to make complicated things as simple and as great as they can be, without leaving out the good stuff.

sorry for the triple post

[edbeard]

I did the border checks and everything was good.


It doesn't show bombardments though but those are easy to check (and already done).



Regarding your last post the problem is whether an override makes you no longer hold that continent or not. Or just stops the bonus. If it makes you no longer hold it, then you cannot hold 'Commissioner + Lieutenant + One Patrol' because the 'Two Patrol' will override the one patrol. It's the question we've been kicking back and forth for a while now. It matters because overrides only work if you hold that continent.

[zimmah]

I did the border checks and everything was good.


It doesn't show bombardments though but those are easy to check (and already done).



Regarding your last post the problem is whether an override makes you no longer hold that continent or not. Or just stops the bonus. If it makes you no longer hold it, then you cannot hold 'Commissioner + Lieutenant + One Patrol' because the 'Two Patrol' will override the one patrol. It's the question we've been kicking back and forth for a while now. It matters because overrides only work if you hold that continent.

whenever you use an override tag in continent B to override continent A, whenever you held both continents, continent B will be granted to you and appear in the logs, however continent A will not be shown in the logs and the bonus will be ignored.

therefore you can conclude, whenever you use continent C to override continent A and B while holding continent A and B (since continent A+B=continent C) you can only hold C (which in fact is A+B in this example) when you hold both A and B first, however it will override them, but AFTER you got the bonus for C, off course only C will appear in the log. so it will tell you hold continent C, even though continents A and B required to hold continent C are overriden by itself. i'm 99% sure about that. it's quite logical in fact.

example:

Code: Select all

<continent>
<name>A
<bonus>0
<components>
<territory>territory 1
<territory>territory 2
<territory>territory 3
</components>
</continent>

<continent>
<name>B
<bonus>0
<components>
<territory>territory 4
</components>
</continent>

<continent>
<name>C
<bonus>500
<components>
<continent>A
<continent>B
</component>
<overrides>
<override>A
<override>B
</overrides>
</continent>



[edbeard]

well lack contradicted what yeti had said about continent overrides. though I could be confused. Either way he didn't give me a direct answer to my question.

Commissioner + Lieutenant + Two Patrol will only override the continents that you put in its overrides section. It wil not override anything else, even continents that are based on stuff in its overrides section.

Since you're the coder, I'm sending this to you. I'm ccing andy on this as well btw.

Here's a quoted post from the Operation Drug War thread.

I'm still a bit concerned about when the overrides come into play.

Do I no longer hold a continent because I've overrided a component that is needed for it to be held?


The reason I ask is because for example

Code: Select all

<continent>
<name>Commissioner + Lieutenant + Two Patrol</name>
<bonus>2</bonus>
<components>
<territory>Commissioner</territory>
<territory>Lieutenant</territory>
<continent>Two Patrol</continent>
</components>
<overrides>
<override>Commissioner + Lieutenant + One Patrol</override>
<override>Two Patrol</override>
</overrides>
</continent>

if I override 'two patrol', then do I no longer hold 'one patrol' since it overrides 'one patrol' and therefore holding the 'commish + lt. + one patrol' combined continent is not possible?


NB: I wanted this to be its own post because it's important.

if this is true then this XML needs to be back to what I had it before with many overrides. And, the Supermax XML needs to be changed too.

[zimmah]

Forza checked and and siad it was good, i will ask him to double check the overrides parts though to be sure.



* Quote Forza AZ

Re: [Official] Map XML checks

Sent at: Mon Jun 09, 2008 12:01 pm
by Forza AZ
Subject: [Official] Map XML checks

zimmah wrote:http://www.conquerclub.com/forum/viewtopic.php?f=64&t=36953

http://img129.imageshack.us/img129/2214 ... 15ltu5.png

http://img150.imageshack.us/img150/9664 ... r15wt0.png

XML: will be reposted later, it might still need some work.


Is the XML already finished? If not, then please finish it first and then I will check it for you.


zimmah wrote:the XML is finished, but there might be some issues around it.

you can check it though http://www.freewebs.com/zimri1987/odw2.xml


I only noticed 1 small mistake:
-Eight Phones bonus: bonus in XML should be 8, not 2.

[zimmah]

we'll have to ask yeti about the overrides, because forza isn't sure either.

[yeti_c]

I'm still pretty confident that I am correct about the overrides chaining down...

Essentially all you need to know - is that the overrides kill the bonus they are related to - they don't stop you from holding the continent itself.

I'm pretty sure I used the technique (successfully) in Iraq - but you're more than welcome to check that out - and run a test game on it.

C.

[zimmah]

I'm still pretty confident that I am correct about the overrides chaining down...

Essentially all you need to know - is that the overrides kill the bonus they are related to - they don't stop you from holding the continent itself.

I'm pretty sure I used the technique (successfully) in Iraq - but you're more than welcome to check that out - and run a test game on it.

C.

then i'd like to know how i can run a test game to see how the overriden bonusses work out.