Script: Game Link - Version 1.6.0

[VampireM]

Yes, script doesn't work correctly when you can invite somebody in the game.

okay thanks for that info, never noticed before... is there any plan to fix this or is it to small it dont matter

[jricart]

Somehow, the script is not working at all right now!

[VampireM]

yeah same, just says details not found.. and now im lost and dont know how to check games anymore:(

[Foxglove]

I think it's because of the server downtime notice on the Game Finder page (which is what I call behind the scenes to grab the game details).

Once it's gone I hope that the script will work properly again!

[jricart]

I think it's because of the server downtime notice on the Game Finder page (which is what I call behind the scenes to grab the game details).

Once it's gone I hope that the script will work properly again!

Thanks for the info

Now we have to wait

[MrGlassB]

I'll be honest; I didn't read this thread. Are there any plans or consideration for doing something similar with the player link? I love this script, but having it pop up player information too would be extremely helpful. I hate the need to click a player link just to see their rank, games, etc.

MGB

[Leehar]

I think it's because of the server downtime notice on the Game Finder page (which is what I call behind the scenes to grab the game details).

Once it's gone I hope that the script will work properly again!

Good to know, I was wondering what the prob was

[Night Strike]

It appears that special site banners break this script. From my Firefox 4 Error Console:

Error: not well-formed
Source File: viewtopic.php?f=82&t=136857&view=unread#unread
Line: 38, Column: 37
Source Code:
<a href="player.php?submit=Search&gs=W&mp=33&pt=N"><img src="http://static.conquerclub.com/banner_pacman.png" align="right" style="float:right;border:none;margin-left:150px;" width="455" height="47" alt="Happy Anniversary Pac-Man" /></a>

[Dako]

As the script author is no longer interested in this script, we can only wait when the banner goes down.

[Bruceswar]

Let me ask fox and see what can be done if anything.

[ender516]

In some cases, the game link information box pops up behind an image in a signature. These images seem to be ones which have "Click image to enlarge" but are still not clickable. (Maybe BigImg doesn't work in a signature.)

[ender516]

This script is not producing anything useful right now. Is that due to the downtime banner, or the round limit change, or what?

EDIT:
This is what happens when I post when I'm tired. I thought I remembered this problem, and if I had had the sense to scroll back about three posts, I would have had my answer. Anyway, the banner is gone and so is the problem (at least, for now).

[sherkaner]

With Foxglove's permission, I've put a version of this on github. Link to that version:

https://github.com/sherkaner/addons-for ... nk.user.js

I've added some changes:
1.) Uses the API to request the game/player information.
2.) Starts retrieving information only when you hover the first game-link.
3.) If the place is reserved, it will display '(reserved)' behind the user for who it is reserved.

This means that a banner won't impact the script any more (since banners aren't part of the API result), page loading times improved if there are a lot of games on a page, and if you don't hover any no work is done to retrieve any data.

Possible bugs:
API doesn't fetch over 100 games or 100 players at once, and I did not prepare for that yet. So on pages with massive amounts of games, it won't fetch everything. For players it might not retrieve the rank of players properly if there are more than 100 players in the games on a page.
Also, in 1 instance I've seen that the API doesn't retrieve a particular player (Noël Bangma in this case), though if I limit the number of players that player is retrieved. Not sure why that happens though, could also be a bug in the API.

[ender516]

It would be good if this worked on pages like "http://www.conquerclub.com/forum/posting.php?*" so you could check game links in the preview pane. By the way, does anyone besides me think that a popup for [player] links might be a nice addition to this script? It could display a Readers' Digest condensed version of the player's profile: score, rank, win/loss, attendance, rating, ... (whatever is available through the API). I would be interested in what parts others would like to see there.

[Dako]

Why don't you make it into single requests on hover? Because it takes a long time to fetch game links anyway and most of the time I need 2-3 games out of 10 only.

As for [player] suggestion - yeah, that will be great as well.

[sherkaner]

Why don't you make it into single requests on hover? Because it takes a long time to fetch game links anyway and most of the time I need 2-3 games out of 10 only.

As for [player] suggestion - yeah, that will be great as well.

Because I tend to use it in tournament or clanwar forum pages, where I'm interested in most of the games.
And I'd have to check, but I think it takes around 0.3 second to fetch 40 games now, that's quite good actually (it just doesn't annoy me). So I didn't need to make it faster, it looks like adding one more game isn't that expensive for the server, and I'm not that sure about firing multiple requests.

[ender516]

Maybe the question is whether there is an advantage to delaying the API request until the first hover. If all the games can be fetched at once with only a minor delay, it might be smoother to do it when the page loads. Most forum users are accustomed to a bit of a delay while loading a page, what with signatures and images and such being loaded. A small extra delay at that point might not be as annoying as the one now at first hover.

The other thing I would like to suggest is extending the @include directives to include https://www... .

[sherkaner]

Maybe the question is whether there is an advantage to delaying the API request until the first hover. If all the games can be fetched at once with only a minor delay, it might be smoother to do it when the page loads. Most forum users are accustomed to a bit of a delay while loading a page, what with signatures and images and such being loaded. A small extra delay at that point might not be as annoying as the one now at first hover.

The other thing I would like to suggest is extending the @include directives to include https://www... .

Actually, my main reason for updating it is introducing that lazy loading, I used to disable the script when going to pages with high amounts of games (clan league if I remember correctly), because that ment the page was a lot slower (10 seconds or so, api should have made it faster). And disabling/enabling is annoying. I could maybe make it an option though.

The https thing is something I can do though (or even you, since you can edit it on github ).

[ender516]

I guess the ultimate option technique would be an adjustable threshold: if there are less than N links on the page, then load immediately, else wait for first hover.

I will take a crack at github very soon. I just want to be sure that I do no damage.

[MrGlassB]

By the way, does anyone besides me think that a popup for [player] links might be a nice addition to this script?

I believe I already mentioned that earlier in the thread. I would love to see a popup for player links.

MGB

[ender516]

By the way, does anyone besides me think that a popup for player links might be a nice addition to this script?

I believe I already mentioned that earlier in the thread. I would love to see a popup for player links.

MGB

I am working on a popup for player links. Right now it is in a separate script for testing purposes, and I am about half done: I have code that will pop up over links that reference users by numerical ID, like those that appear in the header of a post or at the side with the avatars and stuff, but also need to handle links that reference users by name, which is what you get from ender516. Doing both in a simplistic way would be easy, but I am trying to come up with a way to avoid fetching the same user information both ways. Once I work that out, it may be easier to combine this fetching of user information with what Game Link is doing. If that doesn't work out, I will simply release my script separately.

[MrGlassB]

Awesome.

MGB

[sherkaner]

I added the player state to the information (the red/green/yellow thingy indicating whose turn it is) on the github-version, and now it should work for https and thread/post previews too.

[ender516]

I would have taken a shot at the github version as you suggested, but I am having trouble installing git for Cygwin on my PC. I suspect that my disk is too close to full.

[DiM]

for some reason this does not work anymore

i keep getting this: